slackhq / vscode-hack

Hack language & HHVM debugger support for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=pranayagarwal.vscode-hack
MIT License
76 stars 38 forks source link

`shape(...)` declaration seems to break syntax highlighting. #70

Closed mansu closed 4 years ago

mansu commented 5 years ago

It seems that the shape annotation seems to break syntax highlighting in vscode-hack.

Adding shape(...) declaration to any function should repro it. Here is a screenshot with sample code.

Screen Shot 2019-10-16 at 3 37 24 PM
lexidor commented 5 years ago

Related issue #58

tspence commented 5 years ago

Related: https://github.com/slackhq/vscode-hack/pull/69 brings in the latest changes from the Facebook IDE team. I think this may correct the issue.

tspence commented 5 years ago

This appears to be solved with the latest revision to the grammar:

Screenshot 2019-10-17 10 39 25