slackhq / vscode-hack

Hack language & HHVM debugger support for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=pranayagarwal.vscode-hack
MIT License
76 stars 38 forks source link

[Syntax highlighting] New syntax highlighting in v2.7.0 does not handle this case. #74

Open lexidor opened 5 years ago

lexidor commented 5 years ago

Using the older version (and what github appears to be using)

  const dict<string, (function(Webserver\RequestURL): Awaitable<void>)> CONSTANT_NAME = dict[];
//00000 000012222221 33333333333333333333333333333333 33333333333333330 4444444444444 0 0000111

In case github updates their version before you had a chance to see it, this is what I see right now.

0 -> red
1 -> black
2 -> green
3 -> purple
4 -> blue

Using the newer version (2.7.0)

image

The comma behind string is red. The left angle bracket of the Awaitable is red, but the right one is gray. The left paren of the (function) is blue, but the right one is gray. The left angle bracket of the dict is gray, but the right one is white.