Closed lildude closed 5 years ago
As detailed in https://github.com/slackhq/vscode-hack/issues/76, I'm the lead maintainer of https://github.com/github/linguist which uses this grammar for syntax highlighting of Hack files on GitHub.com.
Our grammar compiler has detected an error in your grammar that was introduced in https://github.com/slackhq/vscode-hack/pull/72:
'Repository[type-annotation].Patterns[3].EndCaptures[1]' expected a map, got 'string'
The error is because the first, and only, endCaptures in the fourth pattern of type-annotation is a string:
endCaptures
type-annotation
"endCaptures": { "1": "keyword.operator.key.php" },
It should be a map, ie:
"endCaptures": { "1": { "name": "keyword.operator.key.php" } },
This PR corrects this.
Fixes https://github.com/slackhq/vscode-hack/issues/76
All committers have signed the CLA.
Thanks for the fix @lildude! @tspence could you take a quick look as well if you get the chance?
@PranayAgarwal this was fixed before in #54, the issue was re-introduced by #72
Thanks for the fix!
As detailed in https://github.com/slackhq/vscode-hack/issues/76, I'm the lead maintainer of https://github.com/github/linguist which uses this grammar for syntax highlighting of Hack files on GitHub.com.
Our grammar compiler has detected an error in your grammar that was introduced in https://github.com/slackhq/vscode-hack/pull/72:
The error is because the first, and only,
endCaptures
in the fourth pattern oftype-annotation
is a string:It should be a map, ie:
This PR corrects this.
Fixes https://github.com/slackhq/vscode-hack/issues/76