search

slackhq / vscode-hack

Hack language & HHVM debugger support for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=pranayagarwal.vscode-hack
MIT License
75 stars 37 forks source link

Suggestion: integrate the linguist grammar compiler into CI #80

Open fredemmott opened 5 years ago

fredemmott commented 5 years ago

Detect issues like #54, #76, #78 earlier

PranayAgarwal commented 5 years ago

Hey @lildude, could you point me to the syntax validator used by the linguist repo?

fredemmott commented 5 years ago

pretty sure it's https://github.com/github/linguist/tree/master/tools/grammars/compiler

lildude commented 5 years ago

pretty sure it's https://github.com/github/linguist/tree/master/tools/grammars/compiler

Yup, that’s it. We push a docker image whenever we update the sauce too.

PranayAgarwal commented 3 years ago

I wasn't able to use just the docker container for syntax validation, since it seems to still have a dependency on the repo itself.

Going the full repo route, the compilation seems to raise warnings (on stdout) but there's no way to for the call to result in an error.

@lildude any thoughts on the best approach for this?

lildude commented 3 years ago

I wasn't able to use just the docker container for syntax validation, since it seems to still have a dependency on the repo itself.

Interesting. I've never tried to run it independently of the repo 😁 .

Going the full repo route, the compilation seems to raise warnings (on stdout) but there's no way to for the call to result in an error.

I've not looked at this for a while but legit errors like an invalid regex should cause an error IIRC.