search

slackner / gocryptfs-inspect

Scripts to manually inspect the content of files encrypted with gocryptfs
MIT License
25 stars 5 forks source link

pycryptodome uses Crypto now as the package name #1

Closed swenson closed 3 years ago

swenson commented 3 years ago

Thanks for making this project!

pycryptodome (now?) uses the Crypto package name now, so this small fix is necessary to work with modern versions.

Also, please consider adding a license to this project?

slackner commented 3 years ago

Thanks for your interest in this project.

For now, I've decided to put the project under the MIT license, so it has the same license as gocryptfs itself. Please let me know if that works for you, or if this causes any issues for your planned use-case.

Regarding the patch, I think a better solution is to be compatible with both pycryptodome (import Crypto) and pycryptodomex (import Cryptodome). See here for a difference between both packages: https://stackoverflow.com/questions/48155294/what-is-pycryptodomex-and-how-does-it-differ-from-pycryptodome

  • pycryptodome has some association to pyCrypto and can be considered a drop in replacement when migrating from PyCrypto to PyCryptodome.

  • pycryptodomex is a standalone version of PyCryptodome with a different naming convention; instead of the package Crypto, you have to use Cryptodome. In the case that PyCrypto is required for legacy purposes, pycryptodome should be used.

I've opened https://github.com/slackner/gocryptfs-inspect/pull/2/files with the proposed alternative approach, please let me know if it works for you.

swenson commented 3 years ago

MIT works great. And I think that PR looks good. I'll close this one.

Thanks for getting back so quickly!