slaclab / femto-timing

1 stars 1 forks source link

Vitara 1/2 Obsolescence & Unused "Matlab" PV Dictionaries #8

Closed rlodico06 closed 4 months ago

rlodico06 commented 5 months ago

matlab_pv_base is set to be 'matlab: ' except for the Vitara 1 and Vitara 2 laser lockers.

matlab_pv_offset is 1 for all lockers except Vitara 1 and Vitara 2.

matlab_pv_digits is 2 for all lockers except Vitara 1 and Vitara 2, where it is 3.

matlab_use: Set to false for the first 20 notepad PVs in all lockers.

Long Term Fix: Remove all notepad/matlab PVs. They are currently only used for the drift correction script, and if we decide to continue to develop this script, we can modify it to use standard PVs.

Proposed Short Term Fix: 1) Are the Vitara 1 and Vitara 2 lockers used? If not, delete them. 2) If we delete Vitara 1 and 2, delete the matlab_pv_offset dictionary and hardcode the offset to 1. 3) If we delete Vitara 1 and 2, delete matlab_pv_digits and hardcode the digits to 2. 4) Hardcode the script to ignore the first 20 notepad PVs.