slaclab / lcls-tools

Python tools for LCLS: post processing data, PV handling, pulling archive settings, etc.
Apache License 2.0
2 stars 21 forks source link

Update yaml generator to include device type in yaml file #117

Open nneveu opened 11 months ago

nneveu commented 11 months ago

Is your feature request related to a problem? Please describe. We would like to perform actions on all devices of the same type in an area. i.e. turn off all quads in an area

Describe the solution you'd like Update the yaml files so that the device is type is saved when the yaml file is generated (i.e. quad, bend). This can be done by adding 'key word' to the yaml file metadata.

Describe alternatives you've considered Not having the device type information in yaml (what we have now).

Additional context There may be more information somewhere else / this column (key word) will not help much for screens. Both OTR and YAGS are called 'PROF' in the database.

MattKing06 commented 10 months ago

Similar fix to #103

Do not filter elements from CSV file here

Change element-csv filtering to happen in _extract_devices so we can pass in a required_columns option into it. The required_columns would then be defined here