Creating a new fitting toolkit and examples of how to use it with Screen Profiles.

phys-cgarnier commented 4 months ago

Updating fitting tools, image processing, and screen beam profile measurement classes, draft PR

nneveu commented 4 months ago

Thanks for all your hard work on this! Some initial comments after looking at a few files:

There are a lot of changes here, probably 2-3 PR's worth. I recommend submitting PR's with less changes. I.e. some of the image changes could have been in their own PR vs. being added with the fitting work.
I think plotting should be separate from more fundamental functions like fitting/image processing.
Please rename the PR to something a little more descriptive than Dev, this will help us if we want to look back at the PR later. I suggest relating it to an issue # you are trying to close.

Thanks again, great work!

nneveu commented 1 month ago

@phys-cgarnier @eloiseyang should we close this PR now that it's been reworked/merged elsewhere?

eloiseyang commented 1 month ago

@phys-cgarnier @eloiseyang should we close this PR now that it's been reworked/merged elsewhere?

Let's leave it for now. I might need to use this branch to pull out the last of the changes we haven't yet. Once everything is merged we can close.

slaclab / lcls-tools