search

slaclab / lcls-tools

Python tools for LCLS: post processing data, PV handling, pulling archive settings, etc.
Apache License 2.0
2 stars 20 forks source link

Include Calibration and Statistics PVs as Screen Properties #165

Open eloiseyang opened 3 months ago

eloiseyang commented 3 months ago

Is your feature request related to a problem? Please describe. The profile monitor GUI needs to calibrate screens and broadcast computed beam statistics. It needs to read and write to several different PVs to accomplish these tasks.

Describe the solution you'd like The screen class should include new properties that automatically read/write to the relevant PVs and throw meaningful errors if the PVs are inaccessible. The YAML files should store the relevant PVs to simplify handling different screen types. The relevant PVs are listed below. This list is likely incomplete.

MattKing06 commented 2 months ago

Some of these have been handled in #127 but we were unable to find the relevant PVs for some screens. It might involve running the yaml generation script again and seeing if the meme service has updated these screens with PVs.