Fitting Base Class and Gaussian Model from PR 143

slaclab / lcls-tools

Python tools for LCLS: post processing data, PV handling, pulling archive settings, etc.

Apache License 2.0

2 stars 20 forks source link

Fitting Base Class and Gaussian Model from PR 143 #172

Closed eloiseyang closed 1 month ago

eloiseyang commented 2 months ago

Added MethodBase as an abstract class for all fit methods. Added GaussianModel class using MethodBase. Added ProjectionFit class. Added tests for all the above including datasets. Separated from pull request 143.

eloiseyang commented 1 month ago

@phys-cgarnier added some changes to the way we set parameters in the model. Waiting on a single function fitting tool for physics applications before merging.

eloiseyang commented 1 month ago

Thanks for pushing the beamsize code, @phys-cgarnier. It looks good to me, we just have some flake8 tests failing. If you could fix those I think we're ready to push this branch. We'll want to write some regression tests for the gaussian fit and beamsize scripts too, but I think that can wait for now.

@nneveu can you take a look too?