Updating for wire devices

slaclab / lcls-tools

Python tools for LCLS: post processing data, PV handling, pulling archive settings, etc.

Apache License 2.0

2 stars 20 forks source link

Closed kabanaty closed 1 month ago

kabanaty commented 1 month ago

Updated the wire device file begun by Nicole. Also added code to the yaml generator file for wire devices.

nneveu commented 1 month ago

I think you might also need to resolve the conflicts before the linter will run.

kabanaty commented 1 month ago

I think you might also need to resolve the conflicts before the linter will run.

Conflicts resolved!

kabanaty commented 1 month ago

@nneveu Hi Nicole, I think that I am ready to merge.

The test file test_wire.py is cleaned up, but very minimal at this point. I will update in a future PR.
YAML files are being generated as expected and have been pushed.
I have tested magnets and wires using the newly generated YAML files and they seem to behave as expected.

nneveu commented 1 month ago

@kabanaty feel free to merge now!

nneveu commented 1 month ago

closed #170