Updates for wire devices and yaml generation

slaclab / lcls-tools

Python tools for LCLS: post processing data, PV handling, pulling archive settings, etc.

Apache License 2.0

2 stars 21 forks source link

Updates for wire devices and yaml generation #183

Closed kabanaty closed 2 months ago

kabanaty commented 2 months ago

Updates for wire devices to address issues #168, #169, and #182.

wire.py now has methods to scan and abort wire scans
wire.py has plane-independent methods for setting ranges and plane selection
generate.py now accounts for PV fields (ex. MOTR.VELO) and generates yaml files properly

MattKing06 commented 2 months ago

Would it be possible to add a wire-collection to the Area class in here

I can make an issue if you would rather this be part of a different PR 😄

nneveu commented 2 months ago

Thanks for reviewing @MattKing06 , and thanks for the PR @kabanaty ! I will merge!

nneveu commented 2 months ago

closes #168 #169 #182

nneveu commented 2 months ago

@kabanaty not sure why the merge to main for this PR broke the unit tests. Could you please take a look? From my end it looked like your branch was passing the checks.