slaclab / lcsim

LCSim Java Library
Other
1 stars 5 forks source link

Removed check on integral charge and used abs value to compute strip charge #22

Closed pbutti closed 4 years ago

pbutti commented 4 years ago

Pull request to "fix" the error when computing the strip charge in has 2019 simulation. Discussed with Norman @ slac and agreed on this procedure. Opened pull request for review and integration (if (needed)

omar-moreno commented 4 years ago

Since we aren't using SiStrips to model the Layer 0 sensors, this change doesn't seem necessary anymore. @normangraf thoughts?

normangraf commented 4 years ago

If layers 1 and 2 are not using this anymore then we should be fine without these checks.