search

slaclab / lcsim

LCSim Java Library
Other
1 stars 5 forks source link

Fails on events created in Pythia8 #3

Closed chekanov closed 5 years ago

chekanov commented 7 years ago

Hello, Jeremy

There is another suggestion. I was trying to use the version 3.4, but it fails on Pythia8 events, such as
http://mc.hep.anl.gov/asc/hepsim/events/pp/100tev/qcd_pythia8_ptall/rfull015/tev100_pythia8_jets_pt100_001_hepsim.slcio

I have identified the problem. It comes from org/lcsim/util/heprep/DisplayHitModules.java (drawPolyhedron). My suggestion is to make a warning after line 148:


if ( detelem.getGeometry().getLogicalVolume() != null) {

ISolid solid = detelem.getGeometry().getLogicalVolume().getSolid();

....
else {
               System.out.println("warning: drawPolyhedron in org.lcsim.util.heprep.DisplayHitModules has some null volumes");
               }

with this correction, it works OK. best, Sergei