Newdets - Githubissues

slaclab / psgeom

code for representing the geometry of scattering experiments

Other

2 stars 3 forks source link

Closed tjlane closed 7 years ago

tjlane commented 8 years ago

New detectors pull request. I think this is good to go.

@chrisvam @chuckie82 please review.

tjlane commented 8 years ago

So not in this, which (upon reflection) probably should be added before merge:

tjlane commented 8 years ago

This PR aims to address #10

Currently done:

To be completed soon:

tjlane commented 8 years ago

@chuckie82 coffset changes merged here resolves #16

chuckie82 commented 8 years ago

OK, thanks. Could you show me an example for translate(0,0,Z) that I should be using?

tjlane commented 8 years ago

Super simple:

from psgeom import camera
g = camera.Cspad.from_psana_file('ref_files/refgeom_psana.data')
print g.xyz
g.translate((0,0,-100000))
print g.xyz

chuckie82 commented 8 years ago

I'll add a test for translate roundtrip.

chuckie82 commented 7 years ago

@tjlane Let's merge this PR. It will be easier for me to test out newdets and distance all in one.

tjlane commented 7 years ago

@chuckie82 sorry for the delayed response. I think we can do this. For my records, to be implemented: