slaclab / pysmurf

Other
2 stars 10 forks source link

Inconsistent use of `nsamp`, `n_samp`, and `n_sample` #405

Closed eyyoung24 closed 4 years ago

eyyoung24 commented 4 years ago

Describe the bug

We use different conventions for the number of samples throughout the code.

Expected behavior

Make nsamp consistent everywhere.

eyyoung24 commented 4 years ago

@swh76 Yuka is taking this on. I suggested making them all nsamp. Do you have a preference?

swh76 commented 4 years ago

Nope, sounds great, thanks @yukanak.

yukanak commented 4 years ago

Sounds good!