slaclab / pysmurf

Other
2 stars 9 forks source link

Epics OverflowError #620

Open jlashner opened 3 years ago

jlashner commented 3 years ago

Describe the bug

Rogue logs are full of error messages like this:

1615342538.361129:pyrogue.epicsV3.Value: Error setting value from epics: smurf_server_s3:AMCc:FpgaTopLevel:AppTop:AppCore:SysgenCryo:Base[1]:CryoChannels:etaMagArray
ERROR:pyrogue.Variable.RemoteVariable.AMCc.FpgaTopLevel.AppTop.AppCore.SysgenCryo.Base[2].CryoChannels.etaQ[4]:int too big to convert
Traceback (most recent call last):
  File "/usr/local/src/rogue/python/pyrogue/_Variable.py", line 324, in set
    self._block.set(self, value)
  File "/usr/local/src/rogue/python/pyrogue/_Block.py", line 362, in set
    ba = var._base.toBytes(value)
  File "/usr/local/src/rogue/python/pyrogue/_Model.py", line 128, in toBytes
    ba = value.to_bytes(byteCount(self.bitSize), self.endianness, signed=True)
OverflowError: int too big to convert

Additional details

Doesn't crash or stop us from taking data so I don't think it's urgent, but it does fill up logs and seems like a relatively easy fix to clamp the eta vars or something before setting.

agustiner commented 2 years ago

Yeah not sure where this issue is coming from. Maybe some function calls set_eta_mag_array with some invalid eta_mag parameter? Wontfix for now.