search

slaclab / pysmurf

Other
2 stars 9 forks source link

Bug fixes for play_tes_bipolar_waveform and stop_tes_bipolar_waveform #679

Closed jlashner closed 1 year ago

jlashner commented 2 years ago

Issue

This PR resolves #678.

Description

Solves two bugs in the functions play_tes_bipolar_waveform and stop_tes_bipolar_waveform:

  1. Moves the enable_waveform fuction after the lut tables are set
  2. Resets the tes bias to the set value instead of to 0. (Need to test if this works like I think it does)

This still needs to be tested before merging.

Does this PR break any interface?

agustiner commented 2 years ago

What's the desired setup for testing this?