search

slaclab / pysmurf

Other
2 stars 9 forks source link

Remove set_enable_ramp #690

Closed agustiner closed 2 years ago

agustiner commented 2 years ago

Closes #688

set_enable_ramp times out when writing to its PV. It's not used when turning on the flux ramp. I couldn't find it in pysmurf, sodetlib, or cryo-det. However EnableRampTrigger is used. If EnableRamp isn't actually used anywhere and is not needed for backwards compatibility, we can delete this.

https://github.com/slaclab/pysmurf/blob/41e41c9c568aecd7e350ff2f050be58498c56af9/python/pysmurf/client/command/smurf_command.py#L4461

https://github.com/slaclab/pysmurf/blob/41e41c9c568aecd7e350ff2f050be58498c56af9/python/pysmurf/client/tune/smurf_tune.py#L3200

https://confluence.slac.stanford.edu/display/SMuRF/RTM+firmware?preview=/232089354/233309457/Cryo_RTM_setup_note_v2.pdf

agustiner commented 2 years ago

Currently, i.e. Rogue v4.11.8 and pysmurf v5.0.3, EnableRampTrigger in Rogue is called EnableRamp in the VHDL. So it's fine to remove this line. Potentially, In some very very old version of the SMuRF Rogue Server it was called EnableRamp, but I don't have any evidence for that.