search

slaclab / pysmurf

Other
2 stars 9 forks source link

Fix Voltage bias target in IV curve #695

Closed agustiner closed 2 years ago

agustiner commented 2 years ago

Closes #694

Issue

694

Description

Use the bucketed Voltage bias target when returning the IV analysis.

Does this PR break any interface?

Which interface changed?

NA

What was the interface before the change

NA

What will be the new interface after the change

NA

agustiner commented 2 years ago

Haven't gotten around to testing this, will merge once tested.

rsonka commented 2 years ago

Maybe this is arrogant, but I honestly don't think this needs any actual testing? It's an incredibly simple fix to a very simple bug that I outlined in detail in the issue report.