This PR explicitly enforces use_monitor=False as the default in all pysmurf caget calls in pysmurf so we're compatible with newer versions of pyepics (e.g. 3.5.1+) where the default use_monitor=False was changed to use_monitor=True which at a minimum breaks pysmurf's ability to poll cryostat card registers (and who knows what else). For more details see the github issue https://github.com/slaclab/pysmurf/issues/725. This PR is part of work to try and upgrade some of the software (like Ubuntu and pyepics) in the pysmurf docker because some of the currently used versions are soon to be EOL'd.
Booted a SMuRF system up using jackhammer into @jlashner's experimental dockers with newer software (including version 3.5.1 of pyepics) but with the --skip-setup option. Then ran setup using this pysmurf branch and verified that setup completed successfully and that cryostat card commanding now works as expected with version 3.5.1 of pyepics.
Function interfaces that changed
None - I added the use_monitor keyword to the cryocard do_read and smurf_command _caget functions with default value False so this change is backwards compatible and can be overriden if desired.
Description
This PR explicitly enforces
use_monitor=Falseas the default in all pysmurfcagetcalls in pysmurf so we're compatible with newer versions of pyepics (e.g. 3.5.1+) where the defaultuse_monitor=Falsewas changed touse_monitor=Truewhich at a minimum breaks pysmurf's ability to poll cryostat card registers (and who knows what else). For more details see the github issue https://github.com/slaclab/pysmurf/issues/725. This PR is part of work to try and upgrade some of the software (like Ubuntu and pyepics) in the pysmurf docker because some of the currently used versions are soon to be EOL'd.Github Issue
https://github.com/slaclab/pysmurf/issues/725
Tests done on this branch
Booted a SMuRF system up using
jackhammerinto @jlashner's experimental dockers with newer software (including version 3.5.1 of pyepics) but with the --skip-setup option. Then ran setup using this pysmurf branch and verified that setup completed successfully and that cryostat card commanding now works as expected with version 3.5.1 of pyepics.Function interfaces that changed
None - I added the
use_monitorkeyword to the cryocarddo_readand smurf_command_cagetfunctions with default valueFalseso this change is backwards compatible and can be overriden if desired.