This PR changes blank to address issue #724. We removed instances of the deprecated function set_rtm_slow_dac_enable() and tested the behavior of the hemt1 gate/drain and 50k1 gate/drain amps pre- and post- removal of the function using a multimeter and oscilloscope. In addition, we note that setup should only be run once per power board cycle to prevent undesirable effects if the amps are already powered. Now, setup checks if the system has already been configured, and you cannot run it again unless you force a rerun of setup.
swh76
commented
1 year ago
Description
This PR changes blank to address issue #724. We removed instances of the deprecated function set_rtm_slow_dac_enable() and tested the behavior of the hemt1 gate/drain and 50k1 gate/drain amps pre- and post- removal of the function using a multimeter and oscilloscope. In addition, we note that
setupshould only be run once per power board cycle to prevent undesirable effects if the amps are already powered. Now,setupchecks if the system has already been configured, and you cannot run it again unless you force a rerun ofsetup.Function interfaces that changed
Removed 3 instances of set_rtm_slow_dac_enable() in
smurf_command.pyas shown below https://github.com/slaclab/pysmurf/blob/6d57a474d9fbc39fcf189c2a6b05af75bcd7b849/python/pysmurf/client/command/smurf_command.py#L45892 are from the function set_amp_defaults(), 1 is from the function set_amp_drain_voltage(self, amp, volt).
What will be the new interface after the change
No interface changes ; this change should be invisible to the user.