This PR changes blank to address issue #724. Chatting with SO folks, we actually decided #724 was related to differences in the way folks are configuring systems (and likely due to running setup multiple times, which shouldn't be necessary and is now not allowed by default per https://github.com/slaclab/pysmurf/pull/741), but while investigating this issue, we realized we had some deprecated calls left in some of the RTM slow DAC setting functions in the smurf_command module that needed to be removed. These are no longer necessary because all slow RTM DACs are now enabled by setDefaults which is run during setup. We removed instances of the deprecated function set_rtm_slow_dac_enable() and tested the behavior of the hemt1 gate/drain and 50k1 gate/drain amps pre- and post- removal of the function using a multimeter and oscilloscope. In addition, we note that setup should only be run once per power board cycle to prevent undesirable effects if the amps are already powered. Now, setup checks if the system has already been configured, and you cannot run it again unless you force a rerun of setup.
2 are from the function set_amp_defaults(), 1 is from the function set_amp_drain_voltage(self, amp, volt).
Also adjusted the set_tes_bias_bipolar, set_tes_bias_bipolar_array, and play_tes_bipolar_waveform to have keyword do_enable default value False, so that the user must force calls to the deprecated set_rtm_slow_dac_enable(). They shouldn't ever need to do this.
What will be the new interface after the change
No interface changes ; this change should be invisible to the user.
Description
This PR changes blank to address issue #724. Chatting with SO folks, we actually decided #724 was related to differences in the way folks are configuring systems (and likely due to running
setupmultiple times, which shouldn't be necessary and is now not allowed by default per https://github.com/slaclab/pysmurf/pull/741), but while investigating this issue, we realized we had some deprecated calls left in some of the RTM slow DAC setting functions in thesmurf_commandmodule that needed to be removed. These are no longer necessary because all slow RTM DACs are now enabled by setDefaults which is run duringsetup. We removed instances of the deprecated function set_rtm_slow_dac_enable() and tested the behavior of the hemt1 gate/drain and 50k1 gate/drain amps pre- and post- removal of the function using a multimeter and oscilloscope. In addition, we note thatsetupshould only be run once per power board cycle to prevent undesirable effects if the amps are already powered. Now,setupchecks if the system has already been configured, and you cannot run it again unless you force a rerun ofsetup.Removed 3 instances of set_rtm_slow_dac_enable() in
smurf_command.pyas shown below https://github.com/slaclab/pysmurf/blob/6d57a474d9fbc39fcf189c2a6b05af75bcd7b849/python/pysmurf/client/command/smurf_command.py#L45892 are from the function set_amp_defaults(), 1 is from the function set_amp_drain_voltage(self, amp, volt).
Also adjusted the
set_tes_bias_bipolar,set_tes_bias_bipolar_array, andplay_tes_bipolar_waveformto have keyworddo_enabledefault valueFalse, so that the user must force calls to the deprecated set_rtm_slow_dac_enable(). They shouldn't ever need to do this.What will be the new interface after the change
No interface changes ; this change should be invisible to the user.