search

slaclab / pysmurf

Other
2 stars 9 forks source link

Rogue defaults fix for RTM precision slow DAC configuration to prevent railing fullscale negative for ~1 sec on configure. #763

Closed swh76 closed 1 year ago

swh76 commented 1 year ago

Description

Also addresses pysmurf issue https://github.com/slaclab/pysmurf/issues/753. Fixes subtle issue with Rogue zip file defaults which was causing the RTM precision slow DACs to rail fullscale negative for ~1 sec on pysmurf setup. SO users report seeing significant heating in cryostats during setup, and this is the likely culprit.

Jira Issue

ESCRYODET-924

Tests done on this branch

Fix tested on the bench (see ESCRYODET-924 for details). Should retest in full release.

Function interfaces that changed

No interface changes.

jlashner commented 1 year ago

I assume you just want me to approve this and acknowledge we need to re-build the docker stack?

swh76 commented 1 year ago

@jlashner Yes. Although the PR is stalled because I think travis-ci no longer supports Ubuntu 18.04 so before we can push this fix we need upgrade the dockers. Which version do you use in your dockers?

jlashner commented 1 year ago

We use 20.04, I think upgrading was fairly straight forward. All of our dockers are here if you wanna copy.