search

slaclab / smurf-processor

SMuRF data processor
Other
1 stars 3 forks source link

Removal of master and slave lingo #11

Closed bopopescu closed 4 years ago

bopopescu commented 4 years ago

For diversity reasons, it would be nice to try to avoid 'master' and 'slave' terminology in this repository which can be associated to slavery. The master-slave terminology could be problematic for people in several countries which has the history of slavery like Romania, USA and many others. Thank you for considering the proposal. Let me know if any changes in the PR are needed, I would be happy to implement them.

jesusvasquez333 commented 4 years ago

@bopopescu thank you for the suggestion and for bringing this to our attention. We have discussed this and agree with your proposed change. Unfortunately this code uses an external library which defines this API, so eliminating the terminology isn't as straightforward as a search and replace. However, we have discussed it with the owners of the external library, and they are now thinking about how to eliminate the terms there as well. Once that is done, we would be able to eliminate it here as well.

As this change is not possible at this time, I will close this PR, and fix it once the external library is updated. I moved this request to issue #12 so it can be address in the future.

Thank you, Jesus