slaclab / smurf-processor

SMuRF data processor
Other
1 stars 3 forks source link

Catch all for rogue import #9

Open jlashner opened 4 years ago

jlashner commented 4 years ago

For a while I was having a problem importing my smurf-streamer in python I was getting an error Initialization of SmurfStreamer raised an unreported exception. After looking for a few hours I found this catch all that I didn't copy into my code, which would've told me that the problem came because I didn't import rogue first.

https://github.com/slaclab/smurf-processor/blob/bfe00ed6f4e1ed9ee629f25a68a79fa1e3076eda/src/smurf_processor.cpp#L1136

Can we make the Smurf Processor check if rogue is imported, and throw an informative error if it's not, instead of using a catch all?