search

slaclab / surf

A huge VHDL library for FPGA development
Other
346 stars 55 forks source link

Create ADS1217 ADC #1175

Closed hsandber closed 2 months ago

hsandber commented 4 months ago

Description

Created ADS1217 ADC VHDL module and with matching Python class.

Details

Created a new AxiAds1217Core VHDL module with AXI4-Lite register access to ADC data for all channels. This is a generalized version of modules that have been used in various projects, see for example:

JIRA

Related

hsandber commented 4 months ago

This ADC module only has AXI4-Lite access to the ADC data right now. In some previous applications there has been an AXI4-Stream interface also, which has not been implemented in this generic version of the module yet.

@ruck314, would you prefer to wait until a final version is available with both Lite and Stream interface, or would it better to get this "simpler" version merged in now? I do not have a time estimate for when the final version could be ready.

ruck314 commented 4 months ago 
@ruck314, would you prefer to wait until a final version is available with both Lite and Stream interface, or would it better to get this "simpler" version merged in now? I do not have a time estimate for when the final version could be ready.

@bengineerd Do you want to wait for the stream version of this?

hsandber commented 3 months ago

@bengineerd Do you prefer we close this pull request and delete the branch and then come back at "some point in the future" when the module has been rewritten to match the firmware standards for surf?