Closed zdomke closed 4 days ago
Note: Tests for default model values and model validity will fail with the current version of PyDM (at the time of writing this) as some PyDM models will still return empty QVariants when a request is invalid. I have already made a PR for this: https://github.com/slaclab/pydm/pull/1122
Second Note: Some other test may fail due to a bug in FormulaCurveItems. I already have a PR to fix this bug as well. We can ignore tests with the same error message as the PR: https://github.com/slaclab/pydm/pull/1124
Adding tests for TraceFileConvert
.
Additional fixes that came up during testing
plot_config.py
:
legend_chckbx.stateChanged
signals to bool because it caused an issue in exported filestrace_file_convert.py
:
remove_null_values
ValueError
Adding tests for
ArchiveSearchWidget
andArchiveResultsTableModel
.Fixing issues that came up during testing:
config.py
&config.json
:archiver_urls
because I realized they aren't being used anywhere in the project and could cause confusionarchive_search.py
:logger
to prevent getting a duplicateArchiveResultsTableModel.rowCount
implementation because it requires an argument when it should default to an emptyQModelIndex
ArchiveSearchWidget.archive_url_textedit
with$PYDM_ARCHIVER_URL
instead of hardcoding the URLArchiveSearchWidget.request_archiver_info
, make some wildcards work for 1+ characters instead of just 1 character