Unable to compile nchan with NGINX 1.23.0 mainline...

GerritS76 commented 2 years ago

Have been trying to compile nchan with NGINX 1.23.0 but unfortunately it fails everytime. nginx-comptile-error.txt

tflin commented 2 years ago

That is the pull request https://github.com/slact/nchan/pull/634 trying to solve. @slact Please help to merge it, thanks.

eilandert commented 2 years ago

Some context, the problem with 1.23.0:

Changes with nginx 1.23.0 21 Jun 2022

*) Change in internal API: now header lines are represented as linked
   lists.

plinss commented 1 year ago

I'm unable to build with Nginx 1.23.0 and the current version (with PR #634 merged). This looks like an issue introduced in 49b029cb275433a67b193b505ab999d1831883de

-o objs/addon/memory/ipc.o \
    /build/nginx-1.23.0/debian/modules/nchan/src/store/memory/ipc.c
/build/nginx-1.23.0/debian/modules/nchan/src/store/memory/ipc.c: In function 'ipc_worker_slots':
/build/nginx-1.23.0/debian/modules/nchan/src/store/memory/ipc.c:64:22: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
   64 |   *workerslots_array = ipc->worker_slots;
      |                      ^
cc1: all warnings being treated as errors
make[1]: *** [objs/Makefile:2796: objs/addon/memory/ipc.o] Error 1

slact commented 1 year ago

the discarded qualifiers warning has been fixed as of 1a67d07ffd4fe7971fc2064b53430eb6f6eee514

slact commented 1 year ago

Closing this issue as the PR has been merged and it builds fine now.

slact / nchan

Unable to compile nchan with NGINX 1.23.0 mainline... #641