search

sladage / QtLZMA

LZMA library for Qt.
GNU Lesser General Public License v3.0
20 stars 8 forks source link

Integrated into qt-pods. #1

Closed jacob3141 closed 9 years ago

sladage commented 9 years ago

Looks good, but please don't use #pragma once.

jacob3141 commented 9 years ago

What's the problem with it?

ie. I mean I am replacing include guards with pragma once because it doesn't copy information about the filename (which may change leading to widowed include guard names), looks cleaner and is supported widely. On some systems, it speeds up compilation. Don't get me wrong, I am just curious why you say this.

sladage commented 9 years ago

It's non-standard. Granted, most compilers support it now, but I prefer not to assume everyone is using a compiler with pragma once support.

jacob3141 commented 9 years ago

Ok, I replaced the #pragma once. I will have a further read on this later. Will you be actively maintaining the project? I would like to set your repository as the main source for QtLZMA.

sladage commented 9 years ago

Yeah, not have much time currently but still plan on making some improvements in the near future.