search

slaent / issues

http://slaent.com
6 stars 1 forks source link

Quoted spoiler is spoiled when viewed #83

Open kibner opened 7 years ago

kibner commented 7 years ago

A post contained a spoiler that was inside quote tags. The spoiler content was readable without clicking on it when it should not be. Link to post: http://slaent.com/thread/570154/page/197/post/957445/

I am using the dark theme, as seen here: http://i.imgur.com/17sBmoY.png

todesignandconquer commented 7 years ago

Ah, looks like a case of trying to wrap a blockquote inside a span that has the class spoiler:

image

kibner commented 7 years ago

Kind of piggybacking onto this, but do you want url links to show through a spoiler tag before the user chooses to reveal the spoiler? Because it does that right now, iirc.

todesignandconquer commented 7 years ago

Probably not. That's a good call out. They should only be active if the spoiler is revealed. On Mon, Dec 19, 2016 at 9:09 PM kibner notifications@github.com wrote:

Kind of piggybacking onto this, but do you want url links to show through a spoiler tag before the user chooses to reveal the spoiler? Because it does that right now, iirc.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/slaent/issues/issues/83#issuecomment-268156393, or mute the thread https://github.com/notifications/unsubscribe-auth/AFqB1RuVuw7ZGvgaFyVc6KmZBnXdntYaks5rJ2MIgaJpZM4LRLaA .