search

slagyr / speclj

pronounced "speckle": a TDD/BDD framework for Clojure.
MIT License
458 stars 58 forks source link

Use with redefs in with-stubs macro. #114

Closed HeyBillFinn closed 9 years ago

thesoftwarephilosopher commented 9 years ago

This change could break backwards compatibility somewhat.

HeyBillFinn commented 9 years ago

I'm not sure I follow. Can you come up with an example where this would break backwards compatibility or explain further?

HeyBillFinn commented 9 years ago

Just checking in on this. I can't think of a case where this would break backwards compatibility, but I'm open to hearing otherwise.

trptcolin commented 9 years ago

Looks good to me. Speclj already requires Clojure 1.4+, so there's no issue w/ with-redefs not being available.

Theoretically someone could be trying to run tests in parallel, but there's already precedent for with-redefs in speclj, so that's not a reliable thing to do anyway.

trptcolin commented 9 years ago

Although this change also implies that with-stubbed-invocations (used in should-invoke and should-not-invoke) should also do a with-redefs. What other things might need it? There could be a lot.