This addresses #133, by eliminating the discrepancy between Clojure and ClojureScript classes for SpecFailure and SpecPending. It made sense to me that both should be in speclj.platform, since they are essentially platform-specific implementations of the same APIs.
I verified this against the test repo and instructions provided by milt in #133, as well as in my own project where I encountered the issue.
I was unable to reproduce the issue in specs within the speclj project (in fact, it appears there are already .cljc tests running successfully), but I suspect this has something to do with a difference between how speclj's own specs are compiled and initialized, versus a typical lein-cljsbuild project with the test runner described in README.
slagyr
commented
8 years ago
This addresses #133, by eliminating the discrepancy between Clojure and ClojureScript classes for
SpecFailureandSpecPending. It made sense to me that both should be inspeclj.platform, since they are essentially platform-specific implementations of the same APIs.I verified this against the test repo and instructions provided by milt in #133, as well as in my own project where I encountered the issue.
I was unable to reproduce the issue in specs within the speclj project (in fact, it appears there are already
.cljctests running successfully), but I suspect this has something to do with a difference between how speclj's own specs are compiled and initialized, versus a typicallein-cljsbuildproject with the test runner described in README.