slagyr / speclj

pronounced "speckle": a TDD/BDD framework for Clojure.
MIT License
459 stars 58 forks source link

JUnit reporter #151

Closed eyelidlessness closed 8 years ago

eyelidlessness commented 8 years ago

Addresses #104. Provides a JUnit XML reporter.

Adapts work from the following, which deserve most of the credit:

(But I feel this deserves to be in the main lib.)

Changes to those prior works include:

slagyr commented 8 years ago

This is really cool. A junit reporter is handy. However it can (should) be packaged as a separate library. Note that none of the speclj source files were touched in this commit, a sign of good Open/Close Principle design. The Package Cohesion Principles would have this as a separate package since not all users will need it and shouldn't to pay the cost of extra dependencies and complexity.

The original library (https://github.com/julias-shaw/speclj-junit) is already deployed as a plugin. That's ideal. People who need the JUnit output can simply add it to their project deps.