search

slagyr / speclj

pronounced "speckle": a TDD/BDD framework for Clojure.
MIT License
459 stars 58 forks source link

Here's the change to remove hidden files from clj-files-in function #4

Closed jhirn closed 13 years ago

jhirn commented 13 years ago

Simple enough change.

Again, the reason is because Emacs creates lock files (not temp files) in the directory and it was causing autotest to spin its wheels when editing a file. It could be made to optionally remove them but it seems reasonable enough to never want hidden files.

trptcolin commented 13 years ago

Hey Joe,

We're definitely going to make this change, but I think as part of it we'll extract this duplicated code into a real dependency on the "fresh" library. Do you want to submit a pull request to fresh so you can get credit for it? http://github.com/slagyr/fresh

Otherwise we'll go ahead and make the change there in the next week or so. I'm going to leave this request open as a reminder for us to get it fixed, but won't be merging this in directly, since we want to remove this whole file from speclj.

Thanks!

jhirn commented 13 years ago

Whatever's easiest. Commit credit doesn't matter to me.

On Apr 22, 2011, at 3:09 PM, trptcolinreply@reply.github.com wrote:

Hey Joe,

We're definitely going to make this change, but I think as part of it we'll extract this duplicated code into a real dependency on the "fresh" library. Do you want to submit a pull request to fresh so you can get credit for it? http://github.com/slagyr/fresh

Otherwise we'll go ahead and make the change there in the next week or so. I'm going to leave this request open as a reminder for us to get it fixed, but won't be merging this in directly, since we want to remove this whole file from speclj.

Thanks!

  • Colin

Reply to this email directly or view it on GitHub: https://github.com/slagyr/speclj/pull/4#issuecomment-1045360

slagyr commented 13 years ago

Change was applied to the fresh library.