slagyr / speclj

pronounced "speckle": a TDD/BDD framework for Clojure.
MIT License
459 stars 58 forks source link

Running tests in the leiningen process subverts dependencies #78

Closed gfredericks closed 10 years ago

gfredericks commented 10 years ago

The :eval-in :leiningen change introduced by https://github.com/slagyr/speclj/pull/67 is subtly dangerous as a default setting.

In particular:

This second issue has already resulted in hours of spooky debugging at work (and the details of the libraries involved are reproduced in this skeleton project).

As Phil noted in a comment on the original PR, it takes one line for a user to opt-in to this feature if they want it.

slagyr commented 10 years ago

Thanks for the report. This has been resolved in 3.0.0. The speclj lein task will now set :eval-in to :subprocess and overriding it can be done with :speclj-eval-in :leiningen.