slalombuild / secureli

seCureLI is a tool that enables you to experience the delight of building products by helping you get ideas from your head into working software as frictionlessly as possible, in a reliable, secure, scalable, and observable way.
Apache License 2.0
28 stars 3 forks source link

Abstract out logic that is reused between different actions #361

Open kevin-orlando opened 8 months ago

kevin-orlando commented 8 months ago

Multiple actions call fuctions from other actions e.g. init calling scan and then update and scan calling logic for init/installation. This change should consider refactoring some of the large action specific functions to be reused among different actions.

  1. eliminate calling other actions inside another action. Initialize current calls update, which could potentially lead to unwanted side effects if update action changes.
  2. Separate out action specific logic to be more generic for other actions to use i.e. logging and prompting
  3. Create more generic services or base classes for multiple actions to use.
dlolaogundipe commented 8 months ago

Revisit the code design to be determine if platform can do the check as a one off as opposed to during every scan.

dlolaogundipe commented 7 months ago

Core epic

kevin-orlando commented 7 months ago

Discovery Notes

Areas to refactor

JordoHeffernan commented 6 months ago

There's some good suggestions here that I think could lend themselves to smaller individual tickets to either be included in our current refactor effort, or as a next phase feature a la refactor pt. 2