slalombuild / secureli

seCureLI is a tool that enables you to experience the delight of building products by helping you get ideas from your head into working software as frictionlessly as possible, in a reliable, secure, scalable, and observable way.
Apache License 2.0
28 stars 3 forks source link

feat: Use custom pre-commit config file #411

Closed tdurk93 closed 7 months ago

tdurk93 commented 8 months ago

secureli-373

Migrates .pre-commit-config.yaml into the .secureli/ directory. This directory was previously ignored by git, so I moved its existing contents into .secureli/local/ and told git to only ignore that subfolder. Using a nonstandard path for .pre-commit-config.yaml will allow our tool to not destroy any existing configuration/hooks, and allows us to sidestep much of the complexity of attempting to merge our hooks with existing hooks.

There are a lot of repeated hardcoded strings in this PR. I'm inclined to not do too much refactoring/rework to clean that up, since I'd like to do some significant refactoring in the near future.

Open Questions

Testing

tdurk93 commented 7 months ago

This PR still needs some unit tests but otherwise I think it's pretty much ready for review.