chore: add common action models to shared models folder

[kevin-orlando]

secureli-440

closes #440 Moving common action models to shared models

Changes

• Moves common action models to shared/models/actions.py

Testing

• Verifying the application builds correctly should be enough since this just includes moving existing code to a different file location and updating imports

Clean Code Checklist

• [ ] Meets acceptance criteria for issue
• [ ] New logic is covered with automated tests
• [ ] Appropriate exception handling added
• [ ] Thoughtful logging included
• [ ] Documentation is updated
• [ ] Follow-up work is documented in TODOs
• [ ] TODOs have a ticket associated with them
• [ ] No commented-out code included

[JordoHeffernan]

Apologies for this not being clearer in the AC, but the intent for this ticket was to also go through all the files that currently live in the actions directory (so build.py, scan.py etc.). And move those to the newly created actions.py file. I also think it might help to call that file actions_models.py? I could go either way on that though.

[kevin-orlando]

Apologies for this not being clearer in the AC, but the intent for this ticket was to also go through all the files that currently live in the actions directory (so build.py, scan.py etc.). And move those to the newly created actions.py file. I also think it might help to call that file actions_models.py? I could go either way on that though.

The action file ended up being the only one with model classes, but let me know if I'm missing something!

I named the model file actions.py since it was nested under a model folder already and the import seemed cleaner with secureli.shared.models.actions. Let me know if that works or if the other way seems better.

[JordoHeffernan]

Apologies for this not being clearer in the AC, but the intent for this ticket was to also go through all the files that currently live in the actions directory (so build.py, scan.py etc.). And move those to the newly created actions.py file. I also think it might help to call that file actions_models.py? I could go either way on that though.

The action file ended up being the only one with model classes, but let me know if I'm missing something!

I named the model file actions.py since it was nested under a model folder already and the import seemed cleaner with secureli.shared.models.actions. Let me know if that works or if the other way seems better.

That naming convention works for me, just wanted to double check. And after looking at the other files, you're totally right about action.py being the only file with model classes in it.

@isaac-heist-slalom it is now targeting the refactor branch, if this goes in, are you far enough along that it will cause major MCs? If so maybe hold off just a little bit for this and the other PR that's open to keep going on the restructure