Feature/secureli 460 custom regex - Githubissues

slalombuild / secureli

seCureLI is a tool that enables you to experience the delight of building products by helping you get ideas from your head into working software as frictionlessly as possible, in a reliable, secure, scalable, and observable way.

Apache License 2.0

29 stars 3 forks source link

Feature/secureli 460 custom regex #564

Closed doug-szeto-slalom closed 3 weeks ago

doug-szeto-slalom commented 3 weeks ago

secureli-460

Adds new new-pattern parameter to secureli update and updates secureli scan to check for custom regex

Changes

*

Testing

run secureli update --new-pattern <custom-regex-pattern>
verify that your custom regex pattern was added to .secureli.yaml
modify any file (other than .secureli.yaml) to include text that matches your custom regex
stage the changes
run secureli scan and verify the scan fails
revert the changes and run secureli scan and verify the scan passes

Clean Code Checklist

[x] Meets acceptance criteria for issue
[x] New logic is covered with automated tests
[ x Appropriate exception handling added
[x] Thoughtful logging included
[x] Documentation is updated
[x] Follow-up work is documented in TODOs
[x] TODOs have a ticket associated with them
[x] No commented-out code included

itoltz commented 3 weeks ago

Code looks good. Could you add some info about this new feature to README.md?