`qdecr_model()` is not modular

slamballais / QDECR

The QDECR package for vertex-wise analyses in R

11 stars 0 forks source link

`qdecr_model()` is not modular #3

Closed slamballais closed 5 years ago

slamballais commented 5 years ago

Ideally, QDECR would be perfectly modular.

The qdecr_model function has a hard-coded if-else structure with a fixed number of processes that can be chosen from.

This should be fixed by removing the if-else structure, and rather point directly to a function which will do the preparation step. Users should be able to input the specific prep function into function such as qdecr and qdecr_fastlm.

slamballais commented 5 years ago

This is a complex issue that requires a lot of adjustments:

Add input arguments for qdecr and qdecr_fastlm
Modify qdecr_model to take a specific function as input (argument: prep_fun)
Modify qdecr_model to check prep_fun
Modify qdecr_model to call prep_fun
Come up with consistent names to replace the current functions (probably qdecr_model_*)

I am working on a branch called modular-check-model.

slamballais commented 5 years ago

This was solved in #4 (reverted in #5 ) and #6