search

slambert / Add-Art

Add-Art is a Firefox plugin that replaces ads on websites with rotating curated art images. See also: https://github.com/coreytegeler/add-art-chrome and Safari coming soon...
http://add-art.org
69 stars 27 forks source link

Check for ABP (or equivalent) install and, if missing, prompt user to install. #55

Closed davidhedlund closed 8 years ago

davidhedlund commented 9 years ago

Add-Art can be used with forks of Adblock Plus including Adblock, Adblock Edge, and SpyBlock (part of GNU IceCat).

Please remove the enforced installation of Adblock Plus.

Here's a list of blocking add-ons:

mattkatz commented 9 years ago

That's very interesting and cool! We want to make sure that folks either have one of those installed or that we install one for them. How would we be able to detect it for them?

On March 18, 2015 6:04:54 AM EDT, davidhedlund notifications@github.com wrote:

Add-Art can be used with forks of Adblock Plus including Adblock, Adblock Edge, and SpyBlock (part of GNU IceCat).

Please remove the enforced installation of Adblock Plus. I'm happy with SpyBlock.

Reply to this email directly or view it on GitHub: https://github.com/slambert/Add-Art/issues/55

Sent from Kaiten Mail. Please excuse my brevity.

davidhedlund commented 9 years ago

I'm sure that the "This add-on requires the following add-ons to work properly:" box is just fine in https://addons.mozilla.org/en-US/firefox/addon/add-art/?src=search as its very visible. It does what its suppose to, get attention from the user to install required add-ons by choice.

I would make sure the text goes "This add-on requires one of the following add-ons to work properly:" and add:

to the box.

Please inform Mozilla to add such option if its not possible for you to do so.

slambert commented 9 years ago

@davidhedlund We were planning on doing this in a future release. What @mattkatz was asking is if you know how we can check the users browser to see what is installed. I know this is possible, and easier with the AMO SDK, but any code contributions would be appreciated.

Changing the title of this to reflect the issue.

I think the next release will not be bundled.

dhowe commented 9 years ago

So we are currently checking two options (adblock-plus and adblock-edge), but this code, originally from Add-Art, can prob be expanded to handle more cases (though there may be a better way to do it...)

davidhedlund commented 9 years ago

@dhowe, well, I use SpyBlock that is part of GNU IceCat. IceCat has become very popular recently as its in very active development.

@slambert Also, "adblock" (not to be confused with adblock-edge) is missing in your options.

davidhedlund commented 9 years ago

@dhowe @slambert I've switched to uBlock now, you should add that to the list as well. And uBlock Origin if possible.

slambert commented 9 years ago

@dhowe just went to that link you provided above and got a 404. I think the file you were using isn't in that directory anymore?

dhowe commented 9 years ago

yes, re-organized since then... here you go: https://github.com/dhowe/AdNauseam/blob/master/lib/ff/adncomp.js#L99

owise1 commented 8 years ago

v2 has no dependencies #57