search

slamdata / purescript-jtable

A Purescript table renderer capable of displaying multidimensional, heterogeneous JSON data
14 stars 11 forks source link

Use consistent naming in TableStyle #6

Closed brainrake closed 9 years ago

brainrake commented 9 years ago 
data TableStyle = 
  TableStyle { 
    table   :: Level -> Markup -> Markup,
    cell    :: JSemantic -> Markup -> Markup, 
    head    :: JPath -> Markup -> Markup,
    row     :: Markup -> Markup }

This is inconsistent with the html elements (which Markup represents). instead:

data TableStyle = 
  TableStyle { 
    table   :: Level -> Markup -> Markup,
    td    :: JSemantic -> Markup -> Markup, 
    th    :: JPath -> Markup -> Markup,
    tr     :: Markup -> Markup }
jdegoes commented 9 years ago

I like this suggestion. How about a PR? :smile: