search

slamdata / purescript-markdown-halogen

A Halogen rendering library for purescript-markdown
Apache License 2.0
9 stars 9 forks source link

[SD-1371] Adjust behavior of dropdowns to comport with radio buttons #27

Closed jonsterling closed 8 years ago

jonsterling commented 8 years ago

This should resolve SD-1371 (see discussion in SD-1360.

garyb commented 8 years ago

Build failure?

garyb commented 8 years ago

Oh, it's that timeout thing you mentioned yesterday... hmm.

jonsterling commented 8 years ago

@garyb Looks like it might have been a travis issue (build hung); I'm running it again...

garyb commented 8 years ago

Code change looks good to me though :tangerine:

jonsterling commented 8 years ago

@garyb thanks!

On the side, I really don't understand what could cause the build to hang so frequently at that point... It's very strange that it only happens in Travis (so far).

jonsterling commented 8 years ago

Ok, between my fork and the main repo, that's three times in a row this build has failed; I'm really at a loss. It works fine on my machine...

jonsterling commented 8 years ago

I wonder if the problem was some kind of deadlock or something in gulp. Well, not gulp necessarily I suppose, since I had it happen with pulp yesterday.

jonsterling commented 8 years ago

OK, I don't really understand what's going on with Travis, but I'm going to stick with what I've got now, because it appears to work (for some unknown reason).

garyb commented 8 years ago

It's pretty annoying this has started happening, considering we've not moved to psc 0.8 or anything "major" like that...

jonsterling commented 8 years ago

@garyb Yeah... And one thing I'm surprised by is that this seems to mostly occur (very frequently) on our libraries, but not on SlamData itself. SlamData also builds way faster than these libraries, for some reason (IME). Are we doing something different?

jonsterling commented 8 years ago

I'm squashing everything except the travis "fix" commit, since I want that to be in the commit log so that we can find it later if necessary.