search

slamdata / purescript-markdown

A Purescript library for parsing SlamData's dialect of Markdown.
Other
36 stars 24 forks source link

Update for PureScript 0.7.3, rework eval #38

Closed garyb closed 9 years ago

garyb commented 9 years ago

I originally opened this as having eval and evalM, but I'm doubtful that the non-M version will be useful in the general case, so I dropped it.

I found having a bit more info about what we are evaluating was necessary, breaking it up into four functions seemed the most reasonable way of doing this.

garyb commented 9 years ago

@jdegoes could you cast an eye over this? Or would you rather someone else review?

garyb commented 9 years ago

Ok, this is ready to merge now.

I broke the code and block cases into separate functions too, since the other version was leftover from before when that was the only function eval took.