search

slamdata / purescript-markdown

A Purescript library for parsing SlamData's dialect of Markdown.
Other
36 stars 24 forks source link

[SD-1370] Don't require dropdown default to occur in list of elements #52

Closed jonsterling closed 8 years ago

jonsterling commented 8 years ago

To resolve SD-1370; for more context, see the discussion toward the bottom of SD-1360.

We will adjust purescript-markdown-halogen to treat dropdowns in the same way as radio buttons (adding the default to the list if it is not already present). We will also remove the "dummy" empty value that is currently being added.

garyb commented 8 years ago

:+1:

jonsterling commented 8 years ago

@garyb thanks!

jonsterling commented 8 years ago

@garyb By the way, what sort of version bump do you think this warrants?

garyb commented 8 years ago

I think since we're not preventing any old behaviour, patch?

jonsterling commented 8 years ago

@garyb OK, makes sense—unless, I suppose, someone relied on this state being ruled out. It's so minor I don't think I would worry about it though.