search

slamdata / purescript-quasar

Quasar API library for PureScript
Apache License 2.0
1 stars 7 forks source link

Consider using couchbase standard URI scheme #19

Open ingenthr opened 7 years ago

ingenthr commented 7 years ago

I'm new to PureScript, but after learning a bit more about this I looked into the source to better understand how connections are established and created.

I came across the section on Couchbase URIs.: https://github.com/slamdata/purescript-quasar/blob/32568a09e253a4fe698099f5997d51b32a4a78be/src/Quasar/Mount/Couchbase.purs#L73

You may not have been aware of it, but we do have a documented connection string format that may be useful to use here. It's standardized across all of the SDKs and many of our CLI tools. You'll find details here: https://github.com/couchbaselabs/sdk-rfcs/blob/master/rfc/0011-connection-string.md

One thing I couldn't determine from browsing all of the source is if you're using any of our libs already. You'd, of course, get the connstr for free if you do along with loadbalancing, understanding topology changes, etc.

garyb commented 7 years ago

Thanks for the comment!

This library is for the front-end of SlamData, so the URL format you see here is for the Couchbase connector in Quasar (the back-end component) rather than something that will be used to talk to Couchbase directly.

ingenthr commented 7 years ago

Ah, Quasar was the thing I didn't find when searching github.com/slamdata. :) I'd not followed quite yet all of the dependency graph. Thanks!

By the way, looking underneath, it looks like it's using our client through scala.