search

slamdata / purescript-quasar

Quasar API library for PureScript
Apache License 2.0
1 stars 7 forks source link

add SparkLocal #26

Closed Cmdv closed 7 years ago

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

Cmdv commented 7 years ago

@cryogenian please review :shipit:

cryogenian commented 7 years ago

Thanks! :+1:

garyb commented 7 years ago

Wait... this doesn't look right to me, if this is the format: https://github.com/slamdata/slamdata/issues/1495#issuecomment-288048429

garyb commented 7 years ago

Looks like the value should be a Path Abs Dir Sandboxed rather than a URI in this case?

cryogenian commented 7 years ago

I'd use URI with empty scheme

garyb commented 7 years ago

I think the Pathy version is more appropriate - a URI without a scheme (aka RelativeRef) still allows for query strings and stuff, which I don't think is the case here.

beckyconning commented 7 years ago

@cryogenian please review : )

cryogenian commented 7 years ago

LGTM