Closed ethandeguire closed 6 years ago
Holy moly I didn't realize the tests are completely botched. I'll get them working again but I'm pretty sure that when they were running properly they were all passing...can you give a reproducible example of it failing?
I can work on it later, but I don't believe that even the example solve in the readme/on the github page was working, it got close to a solve, but didnt complete. I could be doing something wrong
On Mon, Jul 23, 2018 at 3:13 PM, Scott McKenzie notifications@github.com wrote:
Holy moly I didn't realize the tests are completely botched. I'll get them working again but I'm pretty sure that when they were running properly they were all passing...can you give a reproducible example of it failing?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/slammayjammay/rubiks-cube-solver/issues/1#issuecomment-407169188, or mute the thread https://github.com/notifications/unsubscribe-auth/AddEvKQqgfTY2YTQJIruyZ3NkWTEab4Dks5uJiA-gaJpZM4Va5S1 .
I got the tests working again and they all pass. The example solve in the readme works as well. I'm just noticing now that I forgot to make a note in the readme that notations are case-sensitive. Could be that?
There’s a good chance it was the case sensitivities, I noticed sometimes it ouputs a lowercase ‘d’ and othertimes uppercase. not sure what’s up with that.
On Jul 24, 2018, at 4:39 PM, Scott McKenzie notifications@github.com wrote:
I got the tests working again and they all pass. The example solve in the readme works as well. I'm just noticing now that I forgot to make a note in the readme that notations are case-sensitive. Could be that?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
Lowercase notation is separate from uppercase notation, they indicate double-layer turns. You can see examples here.
Closing.
The algorithm used for solving works inconsistently, has it been properly tested?