slanatech / swagger-stats

API Observability. Trace API calls and Monitor API performance, health and usage statistics in Node.js Microservices.
https://swaggerstats.io/
MIT License
900 stars 139 forks source link

Change Docs for prom-client as Peer Dependency #128

Closed n0v1 closed 3 years ago

n0v1 commented 3 years ago

Proposed docs change for having prom-client as a peer dependency (see #126 and #127).

ToDo: Replace 'x.x.x' with the actual release version.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 88.396% when pulling 775731ea69eae24bd5cbdcdfe0626cbafc34986f on n0v1:docs-change-prom-client-as-peer-dep into af802b5ffddd463bda47b570413fc805796cab5e on slanatech:master.

n0v1 commented 3 years ago

@sv2 is there a chance you can look at this and create a new (major) release for the peer dependency change? As of npm v7 peer dependencies will be automatically installed.

denny99 commented 3 years ago

@n0v1 Thumbs up for that. Now i am forced to include the prom-client as my own dependency with npm 6